Skip to content

Conversation

paulmenage
Copy link
Contributor

This allows these test modules to pass on builds/targets without unwinding support, where panic = "abort" - the ignored tests are for functionality that's not supported on those targets.

@rustbot
Copy link
Collaborator

rustbot commented Mar 10, 2025

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 10, 2025
This allows these test modules to pass on builds/targets without
unwinding support, where `panic = "abort"` - the ignored tests are for
functionality that's not supported on those targets.
@paulmenage
Copy link
Contributor Author

r? bjorn3

@rustbot rustbot assigned bjorn3 and unassigned Amanieu Mar 21, 2025
@paulmenage paulmenage requested a review from bjorn3 March 21, 2025 18:36
@bjorn3
Copy link
Member

bjorn3 commented Mar 22, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 22, 2025

📌 Commit 9e5c942 has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 22, 2025
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#138018 (rustdoc: Use own logic to print `#[repr(..)]` attributes in JSON output.)
 - rust-lang#138294 (Mark some std tests as requiring `panic = "unwind"`)
 - rust-lang#138468 (rustdoc js: add nonnull helper and typecheck src-script.js)
 - rust-lang#138675 (Add release notes for 1.85.1)
 - rust-lang#138765 (Fix Thread::set_name on cygwin)
 - rust-lang#138786 (Move some driver code around)
 - rust-lang#138793 (target spec check: better error when llvm-floatabi is missing)
 - rust-lang#138822 (De-Stabilize `file_lock`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 53076de into rust-lang:master Mar 23, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 23, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2025
Rollup merge of rust-lang#138294 - paulmenage:test-panic-unwind, r=bjorn3

Mark some std tests as requiring `panic = "unwind"`

This allows these test modules to pass on builds/targets without unwinding support, where `panic = "abort"` - the ignored tests are for functionality that's not supported on those targets.
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Apr 2, 2025
…orn3

Mark some std tests as requiring `panic = "unwind"`

This allows these test modules to pass on builds/targets without unwinding support, where `panic = "abort"` - the ignored tests are for functionality that's not supported on those targets.
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Apr 2, 2025
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#138018 (rustdoc: Use own logic to print `#[repr(..)]` attributes in JSON output.)
 - rust-lang#138294 (Mark some std tests as requiring `panic = "unwind"`)
 - rust-lang#138468 (rustdoc js: add nonnull helper and typecheck src-script.js)
 - rust-lang#138675 (Add release notes for 1.85.1)
 - rust-lang#138765 (Fix Thread::set_name on cygwin)
 - rust-lang#138786 (Move some driver code around)
 - rust-lang#138793 (target spec check: better error when llvm-floatabi is missing)
 - rust-lang#138822 (De-Stabilize `file_lock`)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants